refactor: split monster functions into focused methods#3073
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors two large functions by extracting focused helper methods to improve readability and separation of concerns.
Changes:
- Split
merge_pyproject_tomlinto multiple targeted merge/normalize methods inmetadata.rs. - Split
BuildContextBuilder::buildinto helper resolvers for interpreters, build flags, and SBOM config inbuilder.rs. - Minor flow reordering around platform tag and PyPI validation handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/metadata.rs | Extracts merging logic (version/readme/license/people/deps/entrypoints) into dedicated methods and adds license path normalization helper. |
| src/build_context/builder.rs | Extracts interpreter/build-flag/SBOM resolution into helper methods and adjusts where PyPI validation is computed. |
Split the two largest functions in the codebase:
metadata.rs - merge_pyproject_toml (~260 lines -> 8 methods):
- clear_non_dynamic_fields, merge_version, merge_readme,
merge_license, merge_people, merge_optional_dependencies,
merge_entry_points, normalize_license_paths
builder.rs - BuildContextBuilder::build (~200 lines -> 4 methods):
- resolve_interpreters, resolve_build_flags, resolve_sbom_config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the two largest functions in the codebase:
metadata.rs - merge_pyproject_toml (~260 lines -> 8 methods):
builder.rs - BuildContextBuilder::build (~200 lines -> 4 methods):